adding failover groups to swagger and changing failoverGroupId type#1181
Merged
sergey-shandar merged 1 commit intoAzure:masterfrom May 2, 2017
Merged
adding failover groups to swagger and changing failoverGroupId type#1181sergey-shandar merged 1 commit intoAzure:masterfrom
sergey-shandar merged 1 commit intoAzure:masterfrom
Conversation
…n database resource
sergey-shandar
approved these changes
May 2, 2017
Contributor
Author
|
@jaredmoo, FYI, I sent this out as I am almost done with .NET SDK tests. I will follow up with a pull request for .NET SDK tests. |
Contributor
|
Already merged but looks great anyway :) |
|
No modification for NodeJS |
8 tasks
mccleanp
pushed a commit
that referenced
this pull request
Mar 23, 2022
Adding swagger for Microsoft.Datadog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds Failover Groups back to the public swagger list for Microsoft.Sql since I am in the process of adding .NET SDK tests for Failover Groups, and changes the type of failoverGroupId property in Database resource from Guid to string since this property represents the resource identifier of the failover group that contains the database.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger